feat(storage): Add async client and async http iterator class#1696
feat(storage): Add async client and async http iterator class#1696googlyrahman merged 2 commits intogoogleapis:asyncfrom
Conversation
product-auto-label
bot
added
size: l
Summary of ChangesHello @googlyrahman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces fundamental asynchronous capabilities to the Google Cloud Storage client library. It provides an Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](/s/com/githubusercontent/avatars/G.https/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an experimental asynchronous client for Google Cloud Storage, along with an async HTTP iterator. The implementation looks solid and follows the patterns of the synchronous client. The tests are also comprehensive.
I've left a few comments for improvement:
- A few minor style issues like typos in comments, extra blank lines, and trailing whitespace.
- A suggestion to refactor
_list_resourceto be a synchronous method since it doesn't perform any awaitable operations, which would be a cleaner design. - Some improvements to type hints and defensive copying of parameters.
- A misplaced import in one of the test files.
Overall, great work on adding async support!
googlyrahman
force-pushed
the
dev-1
branch
5 times, most recently
from
9162e46 to
d2460df
Compare
…oogleapis#1696) 1. Add async client implementation. 2. Add AsyncHTTPIterator deriving from google.api_core.page_iterator_async.AsyncIterator as an alternative to google.api_core.page_iterator.HTTPIterator The AsyncHTTPIterator doesn't exists, and hence needs to be implemented.
2 participants
The AsyncHTTPIterator doesn't exists, and hence needs to be implemented.